lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 054/267] rtc: max8997: Fix the returned value in case of error in max8997_rtc_read_alarm()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 41ef3878203cd9218d92eaa07df4b85a2cb128fb ]

    In case of error, we return 0.
    This is spurious and not consistent with the other functions of the driver.
    Propagate the error code instead.

    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/rtc/rtc-max8997.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/rtc/rtc-max8997.c b/drivers/rtc/rtc-max8997.c
    index db984d4bf9526..4cce5bd448f65 100644
    --- a/drivers/rtc/rtc-max8997.c
    +++ b/drivers/rtc/rtc-max8997.c
    @@ -221,7 +221,7 @@ static int max8997_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)

    out:
    mutex_unlock(&info->lock);
    - return 0;
    + return ret;
    }

    static int max8997_rtc_stop_alarm(struct max8997_rtc_info *info)
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-16 18:53    [W:4.076 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site