lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 13/55] staging: wfx: avoid double warning when no more tx policy are available
    Date
    From: Jérôme Pouiller <jerome.pouiller@silabs.com>

    Currently, number of available tx retry policies is checked two times.
    Only one is sufficient.

    Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
    ---
    drivers/staging/wfx/data_tx.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
    index 32e269becd75..c9dea627661f 100644
    --- a/drivers/staging/wfx/data_tx.c
    +++ b/drivers/staging/wfx/data_tx.c
    @@ -169,7 +169,8 @@ static int wfx_tx_policy_get(struct wfx_vif *wvif,
    wfx_tx_policy_build(wvif, &wanted, rates);

    spin_lock_bh(&cache->lock);
    - if (WARN_ON(list_empty(&cache->free))) {
    + if (list_empty(&cache->free)) {
    + WARN(1, "unable to get a valid Tx policy");
    spin_unlock_bh(&cache->lock);
    return WFX_INVALID_RATE_ID;
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-12-16 18:04    [W:4.271 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site