Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 16 Dec 2019 13:21:01 +0100 | Subject | Re: [PATCH 1/1] Fix undefined reference to 'node_reclaim_distance'. |
| |
Hi Gon,
Thanks for your patch!
On Mon, Dec 16, 2019 at 11:35 AM Gon Solo <gonsolo@gmail.com> wrote: > According to https://lkml.org/lkml/2019/12/16/101 and > http://kisskb.ellerman.id.au/kisskb/buildresult/14067948/ building on > sh4 is broken due to a > > page_alloc.c:(.text+0x3148): undefined reference to `node_reclaim_distance'. > > This only happens with CONFIG_NUMA=y (variable used with #ifdef > CONFIG_NUMA at mm/page_alloc.c:3529) and CONFIG_SMP=n (variable defined at > kernel/sched/topology.c:2291 but the whole file to be built depends on > CONFIG_SMP in kernel/sched/Makefile:23. > > Follow the lead of arch/x86/Kconfig:1547 and depend on SMP. > > This assumes that there are no NUMA systems without SMP which is > reasonable I guess.
Unfortunately that may be an x86-centric assumption: on other platforms, there do exist systems with multiple memory banks with different access performance figures.
> Signed-off-by: Gon Solo <gonsolo@gmail.com> > --- > arch/sh/mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/mm/Kconfig b/arch/sh/mm/Kconfig > index 5c8a2ebfc720..cf655d8e8758 100644 > --- a/arch/sh/mm/Kconfig > +++ b/arch/sh/mm/Kconfig > @@ -108,7 +108,7 @@ config VSYSCALL > > config NUMA > bool "Non Uniform Memory Access (NUMA) Support" > - depends on MMU && SYS_SUPPORTS_NUMA > + depends on MMU && SMP && SYS_SUPPORTS_NUMA > select ARCH_WANT_NUMA_VARIABLE_LOCALITY > default n > help
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |