lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: saa7146: Avoid using BUG_ON as an assertion
From
Date

> +++ b/drivers/media/common/saa7146/saa7146_video.c
@@ -345,7 +345,8 @@ static int video_begin(struct saa7146_fh *fh)

- BUG_ON(NULL == fmt);
+ if (NULL == fmt)


Would you like to express a null pointer check in a succinct way?

+ if (!fmt)


Will the tag “Fixes” become helpful for the change description?

Regards,
Markus

\
 
 \ /
  Last update: 2019-12-16 11:23    [W:0.036 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site