lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 035/136] USB: serial: fix runtime PM after driver unbind
    3.16.80-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit d51bdb93ca7e71d7fb30a572c7b47ed0194bf3fe upstream.

    Since commit c2b71462d294 ("USB: core: Fix bug caused by duplicate
    interface PM usage counter") USB drivers must always balance their
    runtime PM gets and puts, including when the driver has already been
    unbound from the interface.

    Leaving the interface with a positive PM usage counter would prevent a
    later bound driver from suspending the device.

    Fixes: c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Link: https://lore.kernel.org/r/20191001084908.2003-4-johan@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/serial/usb-serial.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    --- a/drivers/usb/serial/usb-serial.c
    +++ b/drivers/usb/serial/usb-serial.c
    @@ -317,10 +317,7 @@ static void serial_cleanup(struct tty_st
    serial = port->serial;
    owner = serial->type->driver.owner;

    - mutex_lock(&serial->disc_mutex);
    - if (!serial->disconnected)
    - usb_autopm_put_interface(serial->interface);
    - mutex_unlock(&serial->disc_mutex);
    + usb_autopm_put_interface(serial->interface);

    usb_serial_put(serial);
    module_put(owner);
    \
     
     \ /
      Last update: 2019-12-17 01:58    [W:2.436 / U:1.652 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site