lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 099/136] USB: ldusb: fix control-message timeout
    3.16.80-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 52403cfbc635d28195167618690595013776ebde upstream.

    USB control-message timeouts are specified in milliseconds, not jiffies.
    Waiting 83 minutes for a transfer to complete is a bit excessive.

    Fixes: 2824bd250f0b ("[PATCH] USB: add ldusb driver")
    Reported-by: syzbot+a4fbb3bb76cda0ea4e58@syzkaller.appspotmail.com
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Link: https://lore.kernel.org/r/20191022153127.22295-1-johan@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/misc/ldusb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/misc/ldusb.c
    +++ b/drivers/usb/misc/ldusb.c
    @@ -594,7 +594,7 @@ static ssize_t ld_usb_write(struct file
    1 << 8, 0,
    dev->interrupt_out_buffer,
    bytes_to_write,
    - USB_CTRL_SET_TIMEOUT * HZ);
    + USB_CTRL_SET_TIMEOUT);
    if (retval < 0)
    dev_err(&dev->intf->dev,
    "Couldn't submit HID_REQ_SET_REPORT %d\n",
    \
     
     \ /
      Last update: 2019-12-17 01:57    [W:2.118 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site