lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 007/136] staging: rtl8188eu: fix HighestRate check in odm_ARFBRefresh_8188E()
    3.16.80-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Denis Efremov <efremov@linux.com>

    commit 22d67a01d8d89552b989c9651419824bb4111200 upstream.

    It's incorrect to compare HighestRate with 0x0b twice in the following
    manner "if (HighestRate > 0x0b) ... else if (HighestRate > 0x0b) ...". The
    "else if" branch is constantly false. The second comparision should be
    with 0x03 according to the max_rate_idx in ODM_RAInfo_Init().

    Cc: Michael Straube <straube.linux@gmail.com>
    Signed-off-by: Denis Efremov <efremov@linux.com>
    Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
    Link: https://lore.kernel.org/r/20190926073138.12109-1-efremov@linux.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    [bwh: Backported to 3.16: adjust filename, indentation]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
    +++ b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
    @@ -403,7 +403,7 @@ static int odm_ARFBRefresh_8188E(struct
    pRaInfo->PTModeSS = 3;
    else if (pRaInfo->HighestRate > 0x0b)
    pRaInfo->PTModeSS = 2;
    - else if (pRaInfo->HighestRate > 0x0b)
    + else if (pRaInfo->HighestRate > 0x03)
    pRaInfo->PTModeSS = 1;
    else
    pRaInfo->PTModeSS = 0;
    \
     
     \ /
      Last update: 2019-12-17 01:52    [W:2.806 / U:2.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site