lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 131/267] Input: Fix memory leak in psxpad_spi_probe
    Date
    From: Navid Emamdoost <navid.emamdoost@gmail.com>

    In the implementation of psxpad_spi_probe() the allocated memory for
    pdev is leaked if psxpad_spi_init_ff() or input_register_polled_device()
    fail. The solution is using device managed allocation, like the one used
    for pad. Perform the allocation using
    devm_input_allocate_polled_device().

    Fixes: 8be193c7b1f4 ("Input: add support for PlayStation 1/2 joypads connected via SPI")
    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/input/joystick/psxpad-spi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/input/joystick/psxpad-spi.c
    +++ b/drivers/input/joystick/psxpad-spi.c
    @@ -292,7 +292,7 @@ static int psxpad_spi_probe(struct spi_d
    if (!pad)
    return -ENOMEM;

    - pdev = input_allocate_polled_device();
    + pdev = devm_input_allocate_polled_device(&spi->dev);
    if (!pdev) {
    dev_err(&spi->dev, "failed to allocate input device\n");
    return -ENOMEM;

    \
     
     \ /
      Last update: 2019-12-16 19:52    [W:4.217 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site