lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.3 015/180] staging: rtl8712: fix interface sanity check
    Date
    From: Johan Hovold <johan@kernel.org>

    commit c724f776f048538ecfdf53a52b7a522309f5c504 upstream.

    Make sure to use the current alternate setting when verifying the
    interface descriptors to avoid binding to an invalid interface.

    Failing to do so could cause the driver to misbehave or trigger a WARN()
    in usb_submit_urb() that kernels with panic_on_warn set would choke on.

    Fixes: 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel")
    Cc: stable <stable@vger.kernel.org> # 2.6.37
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Link: https://lore.kernel.org/r/20191210114751.5119-3-johan@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/rtl8712/usb_intf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/rtl8712/usb_intf.c
    +++ b/drivers/staging/rtl8712/usb_intf.c
    @@ -247,7 +247,7 @@ static uint r8712_usb_dvobj_init(struct

    pdvobjpriv->padapter = padapter;
    padapter->eeprom_address_size = 6;
    - phost_iface = &pintf->altsetting[0];
    + phost_iface = pintf->cur_altsetting;
    piface_desc = &phost_iface->desc;
    pdvobjpriv->nr_endpoint = piface_desc->bNumEndpoints;
    if (pusbd->speed == USB_SPEED_HIGH) {

    \
     
     \ /
      Last update: 2019-12-16 19:07    [W:2.395 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site