lkml.org 
[lkml]   [2019]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 10/10] soc: qcom: convert to devm_platform_ioremap_resource
    On Sat, 14 Dec 2019 17:54:47 +0000
    Yangtao Li <tiny.windzz@gmail.com> wrote:

    > Use devm_platform_ioremap_resource() to simplify code.
    >
    > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
    > ---
    > drivers/soc/qcom/llcc-qcom.c | 7 +------
    > drivers/soc/qcom/qcom-geni-se.c | 4 +---
    > drivers/soc/qcom/qcom_aoss.c | 4 +---
    > drivers/soc/qcom/qcom_gsbi.c | 5 +----
    > drivers/soc/qcom/spm.c | 4 +---
    > 5 files changed, 5 insertions(+), 19 deletions(-)
    >
    > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
    > index 429b5a60a1ba..99e19df76889 100644
    > --- a/drivers/soc/qcom/llcc-qcom.c
    > +++ b/drivers/soc/qcom/llcc-qcom.c
    > @@ -387,7 +387,6 @@ static int qcom_llcc_remove(struct platform_device *pdev)
    > static struct regmap *qcom_llcc_init_mmio(struct platform_device *pdev,
    > const char *name)
    > {
    > - struct resource *res;
    > void __iomem *base;
    > struct regmap_config llcc_regmap_config = {
    > .reg_bits = 32,
    > @@ -396,11 +395,7 @@ static struct regmap *qcom_llcc_init_mmio(struct platform_device *pdev,
    > .fast_io = true,
    > };
    >
    > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
    > - if (!res)
    > - return ERR_PTR(-ENODEV);
    > -
    > - base = devm_ioremap_resource(&pdev->dev, res);
    > + base = devm_platform_ioremap_resource(pdev, 0);

    What guarantees do you have that entry 0 matches name?

    I find these changes pointless: they don't add much to the readability
    or maintainability of the code, and instead introduce creative bugs.

    M.
    --
    Jazz is not dead. It just smells funny...

    \
     
     \ /
      Last update: 2019-12-15 11:49    [W:2.135 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site