lkml.org 
[lkml]   [2019]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 1/2] dt-bindings: phy: intel-emmc-phy: Add YAML schema for LGM eMMC PHY
From
Date
Hi,

   Thank you for the review comments.

On 14/12/2019 3:08 AM, Rob Herring wrote:
> On Thu, Dec 12, 2019 at 09:53:19AM +0800, Ramuthevar,Vadivel MuruganX wrote:
>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> Add a YAML schema to use the host controller driver with the
>> eMMC PHY on Intel's Lightning Mountain SoC.
>>
>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> ---
>> .../bindings/phy/intel,lgm-emmc-phy.yaml | 62 ++++++++++++++++++++++
>> 1 file changed, 62 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>> new file mode 100644
>> index 000000000000..aed11258d96d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>> @@ -0,0 +1,62 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/phy/intel,lgm-emmc-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Intel Lightning Mountain(LGM) eMMC PHY Device Tree Bindings
>> +
>> +maintainers:
>> + - Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> +
>> +description: |+
>> + Bindings for eMMC PHY on Intel's Lightning Mountain SoC, syscon
>> + node is used to reference the base address of eMMC phy registers.
>> +
>> + The eMMC PHY node should be the child of a syscon node with the
>> + required property:
>> +
>> + - compatible: Should be one of the following:
>> + "intel,lgm-syscon", "syscon"
>> + - reg:
>> + maxItems: 1
>> +
>> +properties:
>> + compatible:
>> + contains:
> You need to drop 'contains'. That implies other strings can also be
> present.
Sure, I will drop contains..
>> + const: intel,lgm-emmc-phy
>> +
>> + "#phy-cells":
>> + const: 0
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + clock-names:
>> + maxItems: 1
> Drop maxItems. It should be:
>
> const: emmcclk
>
> Or just drop clock-names because you don't really need *-names when
> there is only 1.

Noted, fix it.

With Best Regards
Vadivel
>> +
>> +required:
>> + - "#phy-cells"
>> + - compatible
>> + - reg
>> + - clocks
>> + - clock-names
>> +
>> +examples:
>> + - |
>> + sysconf: chiptop@e0200000 {
>> + compatible = "intel,lgm-syscon", "syscon";
>> + reg = <0xe0200000 0x100>;
>> +
>> + emmc-phy: emmc-phy@a8 {
>> + compatible = "intel,lgm-emmc-phy";
>> + reg = <0x00a8 0x10>;
>> + clocks = <&emmc>;
>> + clock-names = "emmcclk";
>> + #phy-cells = <0>;
>> + };
>> + };
>> +...
>> --
>> 2.11.0
>>

\
 
 \ /
  Last update: 2019-12-16 04:23    [W:0.072 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site