Messages in this thread | | | Date | Sat, 14 Dec 2019 13:58:31 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/boot/KASLR: Fix unused variable warning |
| |
On Wed, Dec 11, 2019 at 09:04:17PM +0800, Zhenzhong Duan wrote: > This patch fixes below warning by moving variable 'i':
Avoid having "This patch" or "This commit" in the commit message. It is tautologically useless.
Also, do
$ git grep 'This patch' Documentation/process
for more details.
> arch/x86/boot/compressed/kaslr.c:698:6: warning: unused variable ‘i’ > [-Wunused-variable]
You could explain here why the warning fires...
> Also use true/false instead of 1/0 for boolean return. > > Fixes: 690eaa532057 ("x86/boot/KASLR: Limit KASLR to extract the > kernel in immovable memory only") > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com> > --- > arch/x86/boot/compressed/kaslr.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-)
WARNING: please, no spaces at the start of a line #45: FILE: arch/x86/boot/compressed/kaslr.c:707: + return true;$
WARNING: please, no spaces at the start of a line #48: FILE: arch/x86/boot/compressed/kaslr.c:709: + return false;$
WARNING: please, no spaces at the start of a line #52: FILE: arch/x86/boot/compressed/kaslr.c:713: + int i;$
ERROR: patch seems to be corrupt (line wrapped?) #60: FILE: arch/x86/boot/compressed/kaslr.c:736: regions(slot_areas full)!\n");
WARNING: please, no spaces at the start of a line #62: FILE: arch/x86/boot/compressed/kaslr.c:737: + return true;$
WARNING: please, no spaces at the start of a line #67: FILE: arch/x86/boot/compressed/kaslr.c:741: + return false;$
$ test-apply.sh /tmp/zhenzhong.duan.01 checking file arch/x86/boot/compressed/kaslr.c patch: **** malformed patch at line 60: regions(slot_areas full)!\n");
I'd be very interested to know how you even managed to create such a well, hm, "patch"?!
For the future, before you send a patch:
- use checkpatch on it - send it to yourself and try applying it first
Thx.
-- Regards/Gruss, Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
| |