Messages in this thread | | | From | Liming Sun <> | Subject | RE: [PATCH v1 1/1] platform/mellanox: fix the mlx-bootctl sysfs | Date | Fri, 13 Dec 2019 15:22:22 +0000 |
| |
Thanks! Updated in v2.
- Liming
> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: Friday, December 13, 2019 5:21 AM > To: Liming Sun <lsun@mellanox.com> > Cc: Andy Shevchenko <andy@infradead.org>; Darren Hart <dvhart@infradead.org>; Vadim Pasternak <vadimp@mellanox.com>; David > Woods <dwoods@mellanox.com>; Platform Driver <platform-driver-x86@vger.kernel.org>; Linux Kernel Mailing List <linux- > kernel@vger.kernel.org> > Subject: Re: [PATCH v1 1/1] platform/mellanox: fix the mlx-bootctl sysfs > > On Mon, Dec 9, 2019 at 9:24 PM Liming Sun <lsun@mellanox.com> wrote: > > > > This is a follow-up commit for the sysfs attributes to change > > from DRIVER_ATTR to DEVICE_ATTR according to some initial comments. > > In such case, it's better to point the sysfs path to the device > > itself instead of the driver. This commit adds the missing > > sysfs_create_group() so the attributes can be created under the > > device. The ABI document is also updated. > > > > Fixes tag, please. > > -- > With Best Regards, > Andy Shevchenko
| |