lkml.org 
[lkml]   [2019]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 02/12] ACPI: thermal: switch to use <linux/units.h> helpers
On Fri, Dec 13, 2019 at 6:03 AM Akinobu Mita <akinobu.mita@gmail.com> wrote:
> 2019年12月12日(木) 0:29 Andy Shevchenko <andy.shevchenko@gmail.com>:
> > On Wed, Dec 11, 2019 at 4:39 PM Akinobu Mita <akinobu.mita@gmail.com> wrote:

> > > } else if (crt > 0) {
> > > - unsigned long crt_k = CELSIUS_TO_DECI_KELVIN(crt);
> > > + unsigned long crt_k =
> > > + celsius_to_deci_kelvin(crt);
> >
> > It used to be one line, why do two?
>
> Because this line over 80 characters. This patch doesn't make this line
> longer, but checkpatch.pl complains about it.

I'm not a maintainer here, but as it was before why not to leave as is
(in terms of line length)?
Supposedly maintainers are okay with it.

> > > pr_info(PREFIX "%s [%s] (%ld C)\n", acpi_device_name(device),
> > > - acpi_device_bid(device), DECI_KELVIN_TO_CELSIUS(tz->temperature));
> > > + acpi_device_bid(device),
> > > + deci_kelvin_to_celsius(tz->temperature));
> >
> > Ditto.
>
> Same as above, checkpatch.pl complains about line over 80 characters.

Same as above.

P.S. checkpatch is recommendation, and not something one must follow.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-12-13 10:09    [W:0.064 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site