Messages in this thread | | | From | "Tan, Ley Foon" <> | Subject | RE: [PATCH] nios2: Fix ioremap | Date | Thu, 12 Dec 2019 08:53:16 +0000 |
| |
> -----Original Message----- > From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck > Sent: Thursday, December 5, 2019 10:41 AM > To: Ley Foon Tan <lftan@altera.com> > Cc: nios2-dev@lists.rocketboards.org; linux-kernel@vger.kernel.org; > Guenter Roeck <linux@roeck-us.net>; Christoph Hellwig <hch@lst.de> > Subject: [PATCH] nios2: Fix ioremap > > Commit 5ace77e0b41a ("nios2: remove __ioremap") removed the following > code, with the argument that cacheflag is always 0 and the expression would > therefore always be false. > > if (IS_MAPPABLE_UNCACHEABLE(phys_addr) && > IS_MAPPABLE_UNCACHEABLE(last_addr) && > !(cacheflag & _PAGE_CACHED)) > return (void __iomem *)(CONFIG_NIOS2_IO_REGION_BASE + > phys_addr); > > This did not take the "!" in the expression into account. Result is that > nios2 images no longer boot. Restoring the removed code fixes the problem. > > Fixes: 5ace77e0b41a ("nios2: remove __ioremap") > Cc: Christoph Hellwig <hch@lst.de> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Will add to next rc. Thanks.
Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>
| |