lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH AUTOSEL 4.14 077/130] rfkill: allocate static minor
    On Tue, Dec 10, 2019 at 05:02:08PM -0500, Sasha Levin wrote:
    > From: Marcel Holtmann <marcel@holtmann.org>
    >
    > [ Upstream commit 8670b2b8b029a6650d133486be9d2ace146fd29a ]
    >
    > udev has a feature of creating /dev/<node> device-nodes if it finds
    > a devnode:<node> modalias. This allows for auto-loading of modules that
    > provide the node. This requires to use a statically allocated minor
    > number for misc character devices.
    >
    > However, rfkill uses dynamic minor numbers and prevents auto-loading
    > of the module. So allocate the next static misc minor number and use
    > it for rfkill.
    >
    > Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    > Link: https://lore.kernel.org/r/20191024174042.19851-1-marcel@holtmann.org
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Signed-off-by: Sasha Levin <sashal@kernel.org>
    > ---
    > include/linux/miscdevice.h | 1 +
    > net/rfkill/core.c | 9 +++++++--
    > 2 files changed, 8 insertions(+), 2 deletions(-)

    This is not needed in older kernels, please do not backport it unless
    the networking developers _REALLY_ think it is necessary.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2019-12-11 08:49    [W:3.345 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site