lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 072/243] net-next/hinic: fix a bug in rx data flow
    Date
    From: Xue Chaojing <xuechaojing@huawei.com>

    [ Upstream commit b1a200484143a727ce293e0f200a543cc7584152 ]

    In rx_alloc_pkts(), there is a loop call of tasklet, which causes
    100% cpu utilization, even no packets are being received. This patch
    fixes this bug.

    Signed-off-by: Xue Chaojing <xuechaojing@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/huawei/hinic/hinic_rx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
    index 4c0f7eda1166c..06b24a92ed7d4 100644
    --- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c
    +++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
    @@ -207,9 +207,9 @@ skb_out:
    wmb(); /* write all the wqes before update PI */

    hinic_rq_update(rxq->rq, prod_idx);
    + tasklet_schedule(&rxq->rx_task);
    }

    - tasklet_schedule(&rxq->rx_task);
    return i;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-11 16:21    [W:4.226 / U:1.588 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site