Messages in this thread | | | Subject | Re: [PATCH net-next 3/6] dt-bindings: net: dsa: add new MT7531 binding to support MT7531 | From | Landen Chao <> | Date | Wed, 11 Dec 2019 22:10:44 +0800 |
| |
Hi Andrew,
On Wed, 2019-12-11 at 00:20 +0800, Andrew Lunn wrote: > > +Example 4: > > + > > +ð { > > + gmac0: mac@0 { > > + compatible = "mediatek,eth-mac"; > > + reg = <0>; > > + phy-mode = "2500base-x"; > > + > > + fixed-link { > > + speed = <1000>; > > + full-duplex; > > + pause; > > + }; > > + }; > > 2500Base-X, but fixed link speed 1000? fixed-link speed should be 2500. I will update it. > > > + port@6 { > > + reg = <6>; > > + label = "cpu"; > > + ethernet = <&gmac0>; > > + phy-mode = "2500base-x"; > > + > > + fixed-link { > > + speed = <1000>; > > + full-duplex; > > + pause; > > + }; > > Same here! I will update it or remove fixed-link block as the discussion in dts thread. > > Andrew
regards Landen
| |