Messages in this thread | | | Subject | Re: [PATCH net-next v3 5/5] ethtool: provide link mode names as a string set | From | Florian Fainelli <> | Date | Wed, 11 Dec 2019 20:12:08 -0800 |
| |
On 12/11/2019 1:58 AM, Michal Kubecek wrote: > Unlike e.g. netdev features, the ethtool ioctl interface requires link mode > table to be in sync between kernel and userspace for userspace to be able > to display and set all link modes supported by kernel. The way arbitrary > length bitsets are implemented in netlink interface, this will be no longer > needed. > > To allow userspace to access all link modes running kernel supports, add > table of ethernet link mode names and make it available as a string set to > userspace GET_STRSET requests. Add build time check to make sure names > are defined for all modes declared in enum ethtool_link_mode_bit_indices. > > Once the string set is available, make it also accessible via ioctl. > > Signed-off-by: Michal Kubecek <mkubecek@suse.cz> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
I would have almost treated the _Half_ modes a special to omit specifying Full for 90% of the remaining modes and save both characters and room for errors, but that's fine this way too. -- Florian
| |