lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver
On Wed, Dec 11, 2019 at 04:57:28PM +0800, Jack Ping CHNG wrote:
> - Added TODO (upstream plan)

Wait, your TODO file references things not even in this patch:

> ---
> drivers/staging/Kconfig | 2 +
> drivers/staging/Makefile | 1 +
> drivers/staging/intel-gwdpa/Kconfig | 22 +
> drivers/staging/intel-gwdpa/Makefile | 5 +
> drivers/staging/intel-gwdpa/TODO | 52 ++
> drivers/staging/intel-gwdpa/gswip/Makefile | 10 +
> drivers/staging/intel-gwdpa/gswip/TODO | 4 +
> drivers/staging/intel-gwdpa/gswip/gswip.h | 399 +++++++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_core.c | 755 +++++++++++++++++++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_core.h | 106 ++++
> drivers/staging/intel-gwdpa/gswip/gswip_dev.c | 184 ++++++
> drivers/staging/intel-gwdpa/gswip/gswip_dev.h | 18 +
> drivers/staging/intel-gwdpa/gswip/gswip_mac.c | 225 ++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_port.c | 296 ++++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_reg.h | 487 ++++++++++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_tbl.c | 345 +++++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_tbl.h | 195 +++++++
> drivers/staging/intel-gwdpa/gswip/lmac.c | 46 ++
> drivers/staging/intel-gwdpa/gswip/mac_cfg.c | 491 ++++++++++++++++
> drivers/staging/intel-gwdpa/gswip/mac_common.h | 237 ++++++++
> drivers/staging/intel-gwdpa/gswip/mac_dev.c | 265 +++++++++
> drivers/staging/intel-gwdpa/gswip/xgmac.c | 636 +++++++++++++++++++++
> drivers/staging/intel-gwdpa/gswip/xgmac.h | 239 ++++++++
> drivers/staging/intel-gwdpa/intel-gwdpa.txt | 264 +++++++++
> 24 files changed, 5284 insertions(+)

<snip>

> --- /dev/null
> +++ b/drivers/staging/intel-gwdpa/TODO
> @@ -0,0 +1,52 @@
> +Intel gateway datapath architecture framework (gwdpa)
> +=====================================================
> +
> +Drivers for gwdpa
> +-----------------
> +1. drivers/staging/intel-gwdpa/gswip
> + patch: switch driver (GSWIP)
> +
> +2. drivers/staging/intel-gwdpa/cqm
> + patch: queue manager (CQM)

Where is this directory?

> +3. drivers/staging/intel-gwdpa/pp
> + patch: packet processor (pp)

And this one?

> +4. drivers/staging/intel-gwdpa/dpm
> + patch: datapath manager (DPM)
> + dependencies: GSWIP, CQM, PP

And this one?

> +5. driver/net/ethernet/intel
> + patch: ethernet driver
> + dependencies: DPM

Why is this listed?

> +6. drivers/staging/intel-gwdpa/dcdp
> + patch: direct connect datapath (DCDP)
> + dependencies: DPM

Where is this one?

> +7.1 drivers/net/wireless
> +7.2 drivers/net/wan
> + patch: wireless driver and DSL driver
> + dependencies: DCDP

What does this even mean?

Have you worked with the Intel Linux networking developers to try to get
this all working properly?

totally confused,

greg k-h

\
 
 \ /
  Last update: 2019-12-11 10:31    [W:0.092 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site