Messages in this thread | | | Subject | Re: [PATCH 10/15] firmware: arm_scmi: Drop logging individual scmi protocol version | From | Cristian Marussi <> | Date | Wed, 11 Dec 2019 18:09:33 +0000 |
| |
On 10/12/2019 14:53, Sudeep Holla wrote: > SCMI firmware and individual protocol versions and other attributes are > now exposed as device attributes through sysfs entries. These debug logs > can be dropped as the same information is available through sysfs. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/firmware/arm_scmi/clock.c | 3 --- > drivers/firmware/arm_scmi/perf.c | 3 --- > drivers/firmware/arm_scmi/power.c | 3 --- > drivers/firmware/arm_scmi/reset.c | 3 --- > drivers/firmware/arm_scmi/sensors.c | 3 --- > 5 files changed, 15 deletions(-) >
LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Cristian
> diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c > index b68736ae7f88..ce8cbefb0aa6 100644 > --- a/drivers/firmware/arm_scmi/clock.c > +++ b/drivers/firmware/arm_scmi/clock.c > @@ -326,9 +326,6 @@ static int scmi_clock_protocol_init(struct scmi_device *dev) > > scmi_version_get(handle, SCMI_PROTOCOL_CLOCK, &version); > > - dev_dbg(handle->dev, "Clock Version %d.%d\n", > - PROTOCOL_REV_MAJOR(version), PROTOCOL_REV_MINOR(version)); > - > cinfo = devm_kzalloc(handle->dev, sizeof(*cinfo), GFP_KERNEL); > if (!cinfo) > return -ENOMEM; > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c > index 8a02dc453894..2ad3bc792692 100644 > --- a/drivers/firmware/arm_scmi/perf.c > +++ b/drivers/firmware/arm_scmi/perf.c > @@ -720,9 +720,6 @@ static int scmi_perf_protocol_init(struct scmi_device *dev) > > scmi_version_get(handle, SCMI_PROTOCOL_PERF, &version); > > - dev_dbg(handle->dev, "Performance Version %d.%d\n", > - PROTOCOL_REV_MAJOR(version), PROTOCOL_REV_MINOR(version)); > - > pinfo = devm_kzalloc(handle->dev, sizeof(*pinfo), GFP_KERNEL); > if (!pinfo) > return -ENOMEM; > diff --git a/drivers/firmware/arm_scmi/power.c b/drivers/firmware/arm_scmi/power.c > index 6267111e38e6..29d72fa7d085 100644 > --- a/drivers/firmware/arm_scmi/power.c > +++ b/drivers/firmware/arm_scmi/power.c > @@ -195,9 +195,6 @@ static int scmi_power_protocol_init(struct scmi_device *dev) > > scmi_version_get(handle, SCMI_PROTOCOL_POWER, &version); > > - dev_dbg(handle->dev, "Power Version %d.%d\n", > - PROTOCOL_REV_MAJOR(version), PROTOCOL_REV_MINOR(version)); > - > pinfo = devm_kzalloc(handle->dev, sizeof(*pinfo), GFP_KERNEL); > if (!pinfo) > return -ENOMEM; > diff --git a/drivers/firmware/arm_scmi/reset.c b/drivers/firmware/arm_scmi/reset.c > index 76f1cee85a06..a49155628ccf 100644 > --- a/drivers/firmware/arm_scmi/reset.c > +++ b/drivers/firmware/arm_scmi/reset.c > @@ -205,9 +205,6 @@ static int scmi_reset_protocol_init(struct scmi_device *dev) > > scmi_version_get(handle, SCMI_PROTOCOL_RESET, &version); > > - dev_dbg(handle->dev, "Reset Version %d.%d\n", > - PROTOCOL_REV_MAJOR(version), PROTOCOL_REV_MINOR(version)); > - > pinfo = devm_kzalloc(handle->dev, sizeof(*pinfo), GFP_KERNEL); > if (!pinfo) > return -ENOMEM; > diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c > index fb3bed4cb171..61e12f2fb587 100644 > --- a/drivers/firmware/arm_scmi/sensors.c > +++ b/drivers/firmware/arm_scmi/sensors.c > @@ -286,9 +286,6 @@ static int scmi_sensors_protocol_init(struct scmi_device *dev) > > scmi_version_get(handle, SCMI_PROTOCOL_SENSOR, &version); > > - dev_dbg(handle->dev, "Sensor Version %d.%d\n", > - PROTOCOL_REV_MAJOR(version), PROTOCOL_REV_MINOR(version)); > - > sinfo = devm_kzalloc(handle->dev, sizeof(*sinfo), GFP_KERNEL); > if (!sinfo) > return -ENOMEM; > -- > 2.17.1 >
| |