lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 124/134] mailbox: imx: Clear the right interrupts at shutdown
    Date
    From: Daniel Baluta <daniel.baluta@nxp.com>

    [ Upstream commit 5f0af07e89199ac51cdd4f25bc303bdc703f4e9c ]

    Make sure to only clear enabled interrupts keeping count
    of the connection type.

    Suggested-by: Oleksij Rempel <o.rempel@pengutronix.de>
    Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
    Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
    Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
    Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mailbox/imx-mailbox.c | 15 +++++++++++++--
    1 file changed, 13 insertions(+), 2 deletions(-)

    diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
    index 9f74dee1a58c7..d28bbd47ff882 100644
    --- a/drivers/mailbox/imx-mailbox.c
    +++ b/drivers/mailbox/imx-mailbox.c
    @@ -217,8 +217,19 @@ static void imx_mu_shutdown(struct mbox_chan *chan)
    if (cp->type == IMX_MU_TYPE_TXDB)
    tasklet_kill(&cp->txdb_tasklet);

    - imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_TIEn(cp->idx) |
    - IMX_MU_xCR_RIEn(cp->idx) | IMX_MU_xCR_GIEn(cp->idx));
    + switch (cp->type) {
    + case IMX_MU_TYPE_TX:
    + imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_TIEn(cp->idx));
    + break;
    + case IMX_MU_TYPE_RX:
    + imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_RIEn(cp->idx));
    + break;
    + case IMX_MU_TYPE_RXDB:
    + imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_GIEn(cp->idx));
    + break;
    + default:
    + break;
    + }

    free_irq(priv->irq, chan);
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-12-11 16:59    [W:3.731 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site