Messages in this thread | | | Date | Wed, 11 Dec 2019 09:24:49 +0100 | From | Michal Kubecek <> | Subject | Re: [PATCH net-next v2 4/5] ethtool: move string arrays into common file |
| |
On Tue, Dec 10, 2019 at 09:27:54PM +0100, Johannes Berg wrote: > > > +++ b/net/ethtool/common.c > > @@ -0,0 +1,85 @@ > > +// SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note > > Is the Linux-syscall-note relevant here? This isn't really used for > syscalls directly? > > The exception says it's "to mark user space API (uapi) header files so > they can be included into non GPL compliant user space application > code".
I'm hardly an expert but almost all occurences of "Linux-syscall-note" are in UAPI headers so you are most likely right. IIRC I copied the line into include/uapi/linux/ethtool_netlink.h (which was the first new file) from neighbor ethtool.h and then used the same in all other files.
I'll send a v3 with "GPL-2.0-only" (as there also seems to be a trend of moving to SPDX v3 identifiers) in a moment.
Michal
> > > +++ b/net/ethtool/common.h > > @@ -0,0 +1,17 @@ > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > Same here. > > johannes >
| |