lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm/edid: Increase size of VDB and CMDB bitmaps to 256 bits
On Tue, Dec 10, 2019 at 02:10:48PM -0800, Thomas Anderson wrote:
> CEA-861-G adds modes up to 219, so increase the size of the
> maps in preparation for adding the new modes to drm_edid.c.
>
> Signed-off-by: Thomas Anderson <thomasanderson@google.com>

Thanks. lgtm. Pushed to drm-misc-next.

PS. I do wonder a bit if we should consider a more economical way to
track this stuff. Not really sure how many bits we can realistically
expect to be set in these bitmasks...

> ---
> include/drm/drm_connector.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index 5f8c3389d46f..17b728d9c73d 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -188,19 +188,19 @@ struct drm_hdmi_info {
>
> /**
> * @y420_vdb_modes: bitmap of modes which can support ycbcr420
> - * output only (not normal RGB/YCBCR444/422 outputs). There are total
> - * 107 VICs defined by CEA-861-F spec, so the size is 128 bits to map
> - * upto 128 VICs;
> + * output only (not normal RGB/YCBCR444/422 outputs). The max VIC
> + * defined by the CEA-861-G spec is 219, so the size is 256 bits to map
> + * up to 256 VICs.
> */
> - unsigned long y420_vdb_modes[BITS_TO_LONGS(128)];
> + unsigned long y420_vdb_modes[BITS_TO_LONGS(256)];
>
> /**
> * @y420_cmdb_modes: bitmap of modes which can support ycbcr420
> - * output also, along with normal HDMI outputs. There are total 107
> - * VICs defined by CEA-861-F spec, so the size is 128 bits to map upto
> - * 128 VICs;
> + * output also, along with normal HDMI outputs. The max VIC defined by
> + * the CEA-861-G spec is 219, so the size is 256 bits to map up to 256
> + * VICs.
> */
> - unsigned long y420_cmdb_modes[BITS_TO_LONGS(128)];
> + unsigned long y420_cmdb_modes[BITS_TO_LONGS(256)];
>
> /** @y420_cmdb_map: bitmap of SVD index, to extraxt vcb modes */
> u64 y420_cmdb_map;
> --
> 2.24.0.525.g8f36a354ae-goog

--
Ville Syrjälä
Intel

\
 
 \ /
  Last update: 2019-12-11 16:42    [W:0.222 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site