Messages in this thread | | | Date | Tue, 10 Dec 2019 16:10:34 +0100 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH 07/10] tty: serial: samsung_tty: use standard debugging macros |
| |
On Tue, Dec 10, 2019 at 03:37:03PM +0100, Greg Kroah-Hartman wrote: > The dbg() macro for the driver is not needed at all, all drivers should > use the common dynamic debugging infrastructure, not roll their own. So > delete the custom macro and convert the driver to use dev_dbg() instead, > providing a lot more information than the previous macro provided. >
Since now we have early console this should be functionally equal and makes sense.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards, Krzysztof
| |