lkml.org 
[lkml]   [2019]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf/smmuv3: Remove the leftover put_cpu() in error path
From
Date
On 10/12/2019 10:46 am, Hanjun Guo wrote:
> In smmu_pmu_probe(), there is put_cpu() in the error path,
> which is wrong because we use raw_smp_processor_id() to
> get the cpu ID, not get_cpu(), remove it.

Bah, somehow that slipped through the last round of review :)

Acked-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> ---
> drivers/perf/arm_smmuv3_pmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c
> index 773128f..fd1d46a 100644
> --- a/drivers/perf/arm_smmuv3_pmu.c
> +++ b/drivers/perf/arm_smmuv3_pmu.c
> @@ -834,7 +834,6 @@ static int smmu_pmu_probe(struct platform_device *pdev)
> out_unregister:
> cpuhp_state_remove_instance_nocalls(cpuhp_state_num, &smmu_pmu->node);
> out_cpuhp_err:
> - put_cpu();
> return err;
> }
>
>

\
 
 \ /
  Last update: 2019-12-10 12:05    [W:3.332 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site