lkml.org 
[lkml]   [2019]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.4 21/71] media: ti-vpe: vpe: fix a v4l2-compliance failure about frame sequence number
    Date
    From: Benoit Parrot <bparrot@ti.com>

    [ Upstream commit 2444846c0dbfa4ead21b621e4300ec32c90fbf38 ]

    v4l2-compliance fails with this message:

    fail: v4l2-test-buffers.cpp(294): \
    (int)g_sequence() < seq.last_seq + 1
    fail: v4l2-test-buffers.cpp(740): \
    buf.check(m2m_q, last_m2m_seq)
    fail: v4l2-test-buffers.cpp(974): \
    captureBufs(node, q, m2m_q, frame_count, true)
    test MMAP: FAIL

    The driver is failing to update the source frame sequence number in the
    vb2 buffer object. Only the destination frame sequence was being
    updated.

    This is only a reporting issue if the user space app actually cares
    about the frame sequence number. But it is fixed nonetheless.

    Signed-off-by: Benoit Parrot <bparrot@ti.com>
    Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/ti-vpe/vpe.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c
    index ca6629ccf82da..aa2870e864f9c 100644
    --- a/drivers/media/platform/ti-vpe/vpe.c
    +++ b/drivers/media/platform/ti-vpe/vpe.c
    @@ -1299,6 +1299,7 @@ static irqreturn_t vpe_irq(int irq_vpe, void *data)
    d_vb->timecode = s_vb->timecode;

    d_vb->sequence = ctx->sequence;
    + s_vb->sequence = ctx->sequence;

    d_q_data = &ctx->q_data[Q_DATA_DST];
    if (d_q_data->flags & Q_DATA_INTERLACED) {
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-12-10 23:34    [W:4.140 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site