lkml.org 
[lkml]   [2019]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 177/177] net: phy: initialise phydev speed and duplex sanely
    Date
    From: Russell King <rmk+kernel@armlinux.org.uk>

    [ Upstream commit a5d66f810061e2dd70fb7a108dcd14e535bc639f ]

    When a phydev is created, the speed and duplex are set to zero and
    -1 respectively, rather than using the predefined SPEED_UNKNOWN and
    DUPLEX_UNKNOWN constants.

    There is a window at initialisation time where we may report link
    down using the 0/-1 values. Tidy this up and use the predefined
    constants, so debug doesn't complain with:

    "Unsupported (update phy-core.c)/Unsupported (update phy-core.c)"

    when the speed and duplex settings are printed.

    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/phy/phy_device.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
    index 6144146aec29d..43c4f358eeb8a 100644
    --- a/drivers/net/phy/phy_device.c
    +++ b/drivers/net/phy/phy_device.c
    @@ -420,8 +420,8 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, int phy_id,
    mdiodev->device_free = phy_mdio_device_free;
    mdiodev->device_remove = phy_mdio_device_remove;

    - dev->speed = 0;
    - dev->duplex = -1;
    + dev->speed = SPEED_UNKNOWN;
    + dev->duplex = DUPLEX_UNKNOWN;
    dev->pause = 0;
    dev->asym_pause = 0;
    dev->link = 0;
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-12-10 22:36    [W:4.166 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site