lkml.org 
[lkml]   [2019]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tcp: remove redundant new line from tcp_event_sk_skb
Thanks for your comments, I am going to append the tag.

Cheers,
Tony Lu

On Fri, Nov 08, 2019 at 04:22:19AM -0800, Eric Dumazet wrote:
>
>
> On 11/8/19 1:50 AM, Tony Lu wrote:
> > This removes '\n' from trace event class tcp_event_sk_skb to avoid
> > redundant new blank line and make output compact.
> >
> > Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> > ---
> > include/trace/events/tcp.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
> > index 2bc9960a31aa..cf97f6339acb 100644
> > --- a/include/trace/events/tcp.h
> > +++ b/include/trace/events/tcp.h
> > @@ -86,7 +86,7 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
> > sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
> > ),
> >
> > - TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s\n",
> > + TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
> > __entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
> > __entry->saddr_v6, __entry->daddr_v6,
> > show_tcp_state_name(__entry->state))
> >
>
> This seems good to me. Only few comments :
>
> I would add a
>
> Fixes: af4325ecc24f ("tcp: expose sk_state in tcp_retransmit_skb tracepoint")
>
> And also CC (I just did in this reply) the author of the above patch to make sure nothing unexpected happens.
>
> Thanks.
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>

\
 
 \ /
  Last update: 2019-11-09 11:35    [W:0.042 / U:2.036 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site