lkml.org 
[lkml]   [2019]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 191/191] x86/efi: fix a -Wtype-limits compilation warning
    Date
    From: Qian Cai <cai@lca.pw>

    [ Upstream commit 919aef44d73d5d0c04213cb1bc31149cc074e65e ]

    Compiling a kernel with W=1 generates this warning,

    arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned
    expression >= 0 is always true [-Wtype-limits]

    Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running ...")
    Signed-off-by: Qian Cai <cai@lca.pw>
    Acked-by: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
    Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/x86/platform/efi/quirks.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/quirks.c
    index 669babcaf245a..c75d5ba732f18 100644
    --- a/arch/x86/platform/efi/quirks.c
    +++ b/arch/x86/platform/efi/quirks.c
    @@ -684,7 +684,7 @@ void efi_recover_from_page_fault(unsigned long phys_addr)
    * Address range 0x0000 - 0x0fff is always mapped in the efi_pgd, so
    * page faulting on these addresses isn't expected.
    */
    - if (phys_addr >= 0x0000 && phys_addr <= 0x0fff)
    + if (phys_addr <= 0x0fff)
    return;

    /*
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-11-10 04:07    [W:4.322 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site