lkml.org 
[lkml]   [2019]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 54/66] crypto: fix a memory leak in rsa-kcs1pad's encryption mode
    Date
    From: Dan Aloni <dan@kernelim.com>

    [ Upstream commit 3944f139d5592790b70bc64f197162e643a8512b ]

    The encryption mode of pkcs1pad never uses out_sg and out_buf, so
    there's no need to allocate the buffer, which presently is not even
    being freed.

    CC: Herbert Xu <herbert@gondor.apana.org.au>
    CC: linux-crypto@vger.kernel.org
    CC: "David S. Miller" <davem@davemloft.net>
    Signed-off-by: Dan Aloni <dan@kernelim.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    crypto/rsa-pkcs1pad.c | 9 ---------
    1 file changed, 9 deletions(-)

    diff --git a/crypto/rsa-pkcs1pad.c b/crypto/rsa-pkcs1pad.c
    index 7830d304dff6f..d58224d808675 100644
    --- a/crypto/rsa-pkcs1pad.c
    +++ b/crypto/rsa-pkcs1pad.c
    @@ -267,15 +267,6 @@ static int pkcs1pad_encrypt(struct akcipher_request *req)
    pkcs1pad_sg_set_buf(req_ctx->in_sg, req_ctx->in_buf,
    ctx->key_size - 1 - req->src_len, req->src);

    - req_ctx->out_buf = kmalloc(ctx->key_size, GFP_KERNEL);
    - if (!req_ctx->out_buf) {
    - kfree(req_ctx->in_buf);
    - return -ENOMEM;
    - }
    -
    - pkcs1pad_sg_set_buf(req_ctx->out_sg, req_ctx->out_buf,
    - ctx->key_size, NULL);
    -
    akcipher_request_set_tfm(&req_ctx->child_req, ctx->child);
    akcipher_request_set_callback(&req_ctx->child_req, req->base.flags,
    pkcs1pad_encrypt_sign_complete_cb, req);
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-11-10 03:50    [W:8.546 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site