lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] memfd: Fix COW issue on MAP_PRIVATE and F_SEAL_FUTURE_WRITE mappings
On Thu, Nov 07, 2019 at 10:33:08PM -0800, Christoph Hellwig wrote:
> > - * Since the F_SEAL_FUTURE_WRITE seals allow for a MAP_SHARED
> > - * read-only mapping, take care to not allow mprotect to revert
> > - * protections.
> > + * Since an F_SEAL_FUTURE_WRITE sealed memfd can be mapped as
> > + * MAP_SHARED and read-only, take care to not allow mprotect to
> > + * revert protections on such mappings. Do this only for shared
> > + * mappings. For private mappings, don't need to mask VM_MAYWRITE
>
> This adds an > 80 char line.

Oh, true. Sorry. Andrew I hate to ask you but since you took the patch
already, could you just the comment for the character limit in the one
you applied?

thanks,

- Joel

\
 
 \ /
  Last update: 2019-11-08 16:36    [W:0.041 / U:49.060 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site