lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2] staging: octeon: fix missing a blank line after declaration

I would like to reiterate my opinion that this checkpatch warning is
bullshit. For large functions, sure. For this kind of function, it's
a waste of space.

On Fri, Nov 08, 2019 at 02:23:29PM +0000, Valery Ivanov wrote:
> This patch fixes "WARNING: Missing a blank line after declarations"
> Issue found by checkpatch.pl
>
> Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
> ---
> Changes in v2:
> - fix huge indentation in commit message
> ---
> drivers/staging/octeon/octeon-stubs.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index d53bd801f440..ed9d44ff148b 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -1375,6 +1375,7 @@ static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
> int port)
> {
> union cvmx_gmxx_rxx_rx_inbnd r;
> +
> r.u64 = 0;
> return r;
> }
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2019-11-08 16:03    [W:0.025 / U:2.464 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site