lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/clk: convert VL struct to struct_size
On Thu, 07 Nov 2019 14:50:01 -0800, Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Gustavo A. R. Silva (2019-10-02 12:20:28)
> > On 9/27/19 13:51, Stephen Kitt wrote:
> > > There are a few manually-calculated variable-length struct allocations
> > > left, this converts them to use struct_size.
> >
> > How did you find this?
> >
> > Please, mention the tool you used to find this in the commit log. With
> > that you can add my
> >
> > Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Any answer? I'm tempted to just apply the patch anyway.

Sorry, I hadn’t seen Gustavo’s email!

I didn’t use anything particularly fancy to find these, my history says

git grep -A1 'kzalloc.*sizeof[^_].*+'

and manual review. I noticed that clk/ had a number of hits, but also commits
to switch to struct_size so I reckoned it was worth pursuing the exercise
there.

Is it worth adding that to the commit message?

Regards,

Stephen
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-11-08 15:59    [W:0.038 / U:2.316 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site