lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net] net: ethernet: mediatek: rework GDM setup flow
From
Date
On Thu, 2019-11-07 at 15:49 -0800, David Miller wrote:
> From: MarkLee <Mark-MC.Lee@mediatek.com>
> Date: Thu, 7 Nov 2019 18:51:35 +0800
>
> > + for (i = 0; i < 2; i++) {
>
> This is a regression, because in the existing code...
>
> > - for (i = 0; i < MTK_MAC_COUNT; i++) {
>
> the proper macro is used instead of a magic constant.
Yes, you are right, I make a mistake here, will correct it in the next
patch
>
> You're doing so many things in one change, it's hard to review
> and audit.
>
> If you're going to consolidate code, do that only in one change.
>
> Then make other functional changes such as putting the chip into
> GDMA_DROP_ALL mode during the stop operation etc.
Thanks for your suggestion, I will separate these changes into
a patch series to make every change to be more clear for its
purpose.


\
 
 \ /
  Last update: 2019-11-08 09:14    [W:0.036 / U:44.472 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site