lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 046/103] mips: txx9: fix iounmap related issue
    Date
    From: Ding Xiang <dingxiang@cmss.chinamobile.com>

    [ Upstream commit c6e1241a82e6e74d1ae5cc34581dab2ffd6022d0 ]

    if device_register return error, iounmap should be called, also iounmap
    need to call before put_device.

    Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
    Reviewed-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
    Signed-off-by: Paul Burton <paul.burton@mips.com>
    Patchwork: https://patchwork.linux-mips.org/patch/20476/
    Cc: ralf@linux-mips.org
    Cc: jhogan@kernel.org
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/mips/txx9/generic/setup.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/arch/mips/txx9/generic/setup.c b/arch/mips/txx9/generic/setup.c
    index 1791a44ee570a..20aaf77166e85 100644
    --- a/arch/mips/txx9/generic/setup.c
    +++ b/arch/mips/txx9/generic/setup.c
    @@ -959,12 +959,11 @@ void __init txx9_sramc_init(struct resource *r)
    goto exit_put;
    err = sysfs_create_bin_file(&dev->dev.kobj, &dev->bindata_attr);
    if (err) {
    - device_unregister(&dev->dev);
    iounmap(dev->base);
    - kfree(dev);
    + device_unregister(&dev->dev);
    }
    return;
    exit_put:
    + iounmap(dev->base);
    put_device(&dev->dev);
    - return;
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-11-08 12:59    [W:4.039 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site