lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] watchdog/softlockup: Report overall time and some cleanup
On Thu 2019-10-24 13:49:25, Petr Mladek wrote:
> This is rework of the softlockup improvements sent as
> https://lkml.kernel.org/r/20190819104732.20966-1-pmladek@suse.com
> based on feedback from Peter Zijlstra.
>
> + merged the two patches
> + moved some cleanup changes into separate patches
> + improved the code and commit messages
>
> The main change is in 2nd patch. It fixes the time spent in softlockup.
>
> Original:
>
> [ 168.277520] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [cat:4865]
> [ 196.277604] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [cat:4865]
> [ 236.277522] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [cat:4865]
> ^^^
>
> New:
>
> [ 480.372418] watchdog: BUG: soft lockup - CPU#2 stuck for 26s! [cat:4943]
> [ 508.372359] watchdog: BUG: soft lockup - CPU#2 stuck for 52s! [cat:4943]
> [ 548.372359] watchdog: BUG: soft lockup - CPU#2 stuck for 89s! [cat:4943]
> [ 576.372351] watchdog: BUG: soft lockup - CPU#2 stuck for 115s! [cat:4943]
> ^^^^^
> 1st and 3rd patch clean up the code.
>
>
> Petr Mladek (3):
> watchdog/softlockup: Remove obsolete check of last reported task
> watchdog/softlockup: Report the overall time of softlockups
> watchdog/softlockup: Remove logic that tried to prevent repeated
> reports
>
> kernel/watchdog.c | 67 ++++++++++++++++++++++++-------------------------------
> 1 file changed, 29 insertions(+), 38 deletions(-)

Gently ping. I wonder if there is still chance to get this for 5.5.

I hope that this variant is much easier to review than
the previous one.

Best Regards,
Petr

\
 
 \ /
  Last update: 2019-11-08 11:14    [W:0.033 / U:4.884 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site