lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 50/50] kernel: Rename show_stack_loglvl() => show_stack()
Hi Dmitry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.4-rc6]
[cannot apply to next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Dmitry-Safonov/kallsyms-printk-Add-loglvl-to-print_ip_sym/20191108-124037
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 847120f859cc45e074204f4cf33c8df069306eb2
config: s390-allnoconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=s390

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

arch/s390/kernel/dumpstack.c: In function 'show_regs':
>> arch/s390/kernel/dumpstack.c:178:3: error: too few arguments to function 'show_stack'
show_stack(NULL, (unsigned long *) regs->gprs[15]);
^~~~~~~~~~
arch/s390/kernel/dumpstack.c:126:6: note: declared here
void show_stack(struct task_struct *task, unsigned long *stack,
^~~~~~~~~~

vim +/show_stack +178 arch/s390/kernel/dumpstack.c

1bca09f7144450 Heiko Carstens 2013-03-14 171
1bca09f7144450 Heiko Carstens 2013-03-14 172 void show_regs(struct pt_regs *regs)
1bca09f7144450 Heiko Carstens 2013-03-14 173 {
a43cb95d547a06 Tejun Heo 2013-04-30 174 show_regs_print_info(KERN_DEFAULT);
1bca09f7144450 Heiko Carstens 2013-03-14 175 show_registers(regs);
1bca09f7144450 Heiko Carstens 2013-03-14 176 /* Show stack backtrace if pt_regs is from kernel mode */
1bca09f7144450 Heiko Carstens 2013-03-14 177 if (!user_mode(regs))
2b7b9817c2dbfc Heiko Carstens 2017-06-06 @178 show_stack(NULL, (unsigned long *) regs->gprs[15]);
1bca09f7144450 Heiko Carstens 2013-03-14 179 show_last_breaking_event(regs);
1bca09f7144450 Heiko Carstens 2013-03-14 180 }
1bca09f7144450 Heiko Carstens 2013-03-14 181

:::::: The code at line 178 was first introduced by commit
:::::: 2b7b9817c2dbfce0501a313db817718fc5ef6524 s390/dumpstack: remove raw stack dump

:::::: TO: Heiko Carstens <heiko.carstens@de.ibm.com>
:::::: CC: Martin Schwidefsky <schwidefsky@de.ibm.com>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2019-11-08 11:09    [W:0.051 / U:4.528 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site