lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] list: add hlist_unhashed_lockless()
On Fri, Nov 08, 2019 at 12:17:49PM -0800, Eric Dumazet wrote:
> On Fri, Nov 8, 2019 at 11:24 AM Paul E. McKenney <paulmck@kernel.org> wrote:
> >
> > On Thu, Nov 07, 2019 at 11:37:37AM -0800, Eric Dumazet wrote:
> > > We would like to use hlist_unhashed() from timer_pending(),
> > > which runs without protection of a lock.
> > >
> > > Note that other callers might also want to use this variant.
> > >
> > > Instead of forcing a READ_ONCE() for all hlist_unhashed()
> > > callers, add a new helper with an explicit _lockless suffix
> > > in the name to better document what is going on.
> > >
> > > Also add various WRITE_ONCE() in __hlist_del(), hlist_add_head()
> > > and hlist_add_before()/hlist_add_behind() to pair with
> > > the READ_ONCE().
> > >
> > > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > > Cc: "Paul E. McKenney" <paulmck@kernel.org>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> >
> > I have queued this, but if you prefer it go some other way:
> >
> > Acked-by: Paul E. McKenney <paulmck@kernel.org>
> >
> > But shouldn't the uses in include/linux/rculist.h also be converted
> > into the patch below? If so, I will squash the following into your
> > patch.
> >
> > Thanx, Paul
> >
> > ------------------------------------------------------------------------
>
> Agreed, thanks for the addition of this Paul.

Very good, squashed and pushed, thank you!

Thanx, Paul

\
 
 \ /
  Last update: 2019-11-09 00:43    [W:0.045 / U:8.736 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site