Messages in this thread | | | From | Li Yang <> | Date | Fri, 8 Nov 2019 14:59:18 -0600 | Subject | Re: [PATCH -next] soc: fsl: Enable COMPILE_TEST |
| |
On Fri, Nov 8, 2019 at 9:20 AM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > > Hi, > > On 08/11/2019 21:02:13+0800, YueHaibing wrote: > > When do COMPILE_TEST buiding for RTC_DRV_FSL_FTM_ALARM, > > we get this warning: > > > > WARNING: unmet direct dependencies detected for FSL_RCPM > > Depends on [n]: PM_SLEEP [=y] && (ARM || ARM64) > > Selected by [m]: > > - RTC_DRV_FSL_FTM_ALARM [=m] && RTC_CLASS [=y] && (ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST [=y]) > > > > This enable COMPILE_TEST for FSL_RCPM to fix the issue. > > > > Fixes: e1c2feb1efa2 ("rtc: fsl-ftm-alarm: allow COMPILE_TEST") > > I've removed that patch until the fsl maintainers apply this one.
I think it is wrong to have RTC_DRV_FSL_FTM_ALARM select FSL_RCPM from the begining. The FTM_ALARM is primarily used as a wakeup source for the deep sleep. But it shouldn't be depending on it or selecting it. I will create a patch to move that.
Regards, Leo
> > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > --- > > In commit c6c2d36bc46f ("rtc: fsl-ftm-alarm: Fix build error without PM_SLEEP") > > I posted a wrong kconfig warning(which PM_SLEEP is n), sorry for confusion. > > --- > > drivers/soc/fsl/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig > > index 4df32bc..e142662 100644 > > --- a/drivers/soc/fsl/Kconfig > > +++ b/drivers/soc/fsl/Kconfig > > @@ -43,7 +43,7 @@ config DPAA2_CONSOLE > > > > config FSL_RCPM > > bool "Freescale RCPM support" > > - depends on PM_SLEEP && (ARM || ARM64) > > + depends on PM_SLEEP && (ARM || ARM64 || COMPILE_TEST) > > help > > The NXP QorIQ Processors based on ARM Core have RCPM module > > (Run Control and Power Management), which performs all device-level > > -- > > 2.7.4 > > > > > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
| |