Messages in this thread | | | Date | Fri, 8 Nov 2019 21:53:11 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] mmc: mmc_spi: Use proper debounce time for CD GPIO |
| |
On Fri 2019-11-08 17:09:00, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > According to the comment, board files used to specify 1 ms for the > debounce time. gpiod_set_debounce() needs the debounce time to be > specified in units of microseconds, so make sure to multiply the value > by 1000. > > Note that, according to the git log, the board files actually did > specify 1 us for bounce times, but that seems really low. Device tree > bindings for this type of GPIO typically specify the debounce times in > milliseconds, so setting this default value to 1 ms seems like it would > be somewhat safer. > > Signed-off-by: Thierry Reding <treding@nvidia.com>
Acked-by: Pavel Machek <pavel@denx.de>
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany [unhandled content-type:application/pgp-signature] | |