lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 10/79] ASoC: wm_adsp: Dont generate kcontrols without READ flags
    Date
    From: Stuart Henderson <stuarth@opensource.cirrus.com>

    [ Upstream commit 3ae7359c0e39f42a96284d6798fc669acff38140 ]

    User space always expects to be able to read ALSA controls, so ensure
    no kcontrols are generated without an appropriate READ flag. In the case
    of a read of such a control zeros will be returned.

    Signed-off-by: Stuart Henderson <stuarth@opensource.cirrus.com>
    Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
    Link: https://lore.kernel.org/r/20191002084240.21589-1-ckeepax@opensource.cirrus.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/wm_adsp.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
    index ee85056a85774..b114fc7b2a95e 100644
    --- a/sound/soc/codecs/wm_adsp.c
    +++ b/sound/soc/codecs/wm_adsp.c
    @@ -1147,8 +1147,7 @@ static unsigned int wmfw_convert_flags(unsigned int in, unsigned int len)
    }

    if (in) {
    - if (in & WMFW_CTL_FLAG_READABLE)
    - out |= rd;
    + out |= rd;
    if (in & WMFW_CTL_FLAG_WRITEABLE)
    out |= wr;
    if (in & WMFW_CTL_FLAG_VOLATILE)
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-08 20:18    [W:2.741 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site