lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.3 008/140] arm64: dts: allwinner: a64: sopine-baseboard: Add PHY regulator delay
    Date
    From: Jernej Skrabec <jernej.skrabec@siol.net>

    [ Upstream commit ccdf3aaa27ded6db9a93eed3ca7468bb2353b8fe ]

    It turns out that sopine-baseboard needs same fix as pine64-plus
    for ethernet PHY. Here too Realtek ethernet PHY chip needs additional
    power on delay to properly initialize. Datasheet mentions that chip
    needs 30 ms to be properly powered on and that it needs some more time
    to be initialized.

    Fix that by adding 100ms ramp delay to regulator responsible for
    powering PHY.

    Note that issue was found out and fix tested on pine64-lts, but it's
    basically the same as sopine-baseboard, only layout and connectors
    differ.

    Fixes: bdfe4cebea11 ("arm64: allwinner: a64: add Ethernet PHY regulator for several boards")
    Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
    Signed-off-by: Maxime Ripard <mripard@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    .../boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
    index e6fb9683f2135..25099202c52c9 100644
    --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
    +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
    @@ -159,6 +159,12 @@
    };

    &reg_dc1sw {
    + /*
    + * Ethernet PHY needs 30ms to properly power up and some more
    + * to initialize. 100ms should be plenty of time to finish
    + * whole process.
    + */
    + regulator-enable-ramp-delay = <100000>;
    regulator-name = "vcc-phy";
    };

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-08 20:15    [W:4.274 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site