lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.3 137/140] selftests/powerpc: Fix compile error on tlbie_test due to newer gcc
    Date
    From: Desnes A. Nunes do Rosario <desnesn@linux.ibm.com>

    commit 5b216ea1c40cf06eead15054c70e238c9bd4729e upstream.

    Newer versions of GCC (>= 9) demand that the size of the string to be
    copied must be explicitly smaller than the size of the destination.
    Thus, the NULL char has to be taken into account on strncpy.

    This will avoid the following compiling error:

    tlbie_test.c: In function 'main':
    tlbie_test.c:639:4: error: 'strncpy' specified bound 100 equals destination size
    strncpy(logdir, optarg, LOGDIR_NAME_SIZE);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

    Signed-off-by: Desnes A. Nunes do Rosario <desnesn@linux.ibm.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20191003211010.9711-1-desnesn@linux.ibm.com
    Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    tools/testing/selftests/powerpc/mm/tlbie_test.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/tools/testing/selftests/powerpc/mm/tlbie_test.c
    +++ b/tools/testing/selftests/powerpc/mm/tlbie_test.c
    @@ -636,7 +636,7 @@ int main(int argc, char *argv[])
    nrthreads = strtoul(optarg, NULL, 10);
    break;
    case 'l':
    - strncpy(logdir, optarg, LOGDIR_NAME_SIZE);
    + strncpy(logdir, optarg, LOGDIR_NAME_SIZE - 1);
    break;
    case 't':
    run_time = strtoul(optarg, NULL, 10);

    \
     
     \ /
      Last update: 2019-11-08 20:12    [W:4.096 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site