lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: KCSAN: data-race in __alloc_file / __alloc_file
    On Fri, Nov 8, 2019 at 9:22 AM Eric Dumazet <edumazet@google.com> wrote:
    >
    > Ok, so what do you suggest next ?
    >
    > Declare KCSAN useless because too many false positives ?

    I'd hope that there is some way to mark the cases we know about where
    we just have a flag. I'm not sure what KCSAN uses right now - is it
    just the "volatile" that makes KCSAN ignore it, or are there other
    ways to do it?

    "volatile" has huge problems with code generation for gcc. It would
    probably be fine for "not_rcu" in this case, but I'd like to avoid it
    in general otherwise, which is why I wonder if there are other
    options.

    But worst comes to worst, I'd be ok with a WRITE_ONCE() and a comment
    about why (and the reason being KCSAN, not the questionable
    optimization).

    Linus

    \
     
     \ /
      Last update: 2019-11-08 18:40    [W:4.206 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site