Messages in this thread | | | Date | Fri, 8 Nov 2019 09:35:50 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 10/14] soundwire: intel: add prepare support in sdw dai driver |
| |
On 04-11-19, 15:31, Pierre-Louis Bossart wrote: > > > On 11/4/19 1:45 PM, Cezary Rojewski wrote: > > On 2019-10-23 23:28, Pierre-Louis Bossart wrote: > > > From: Rander Wang <rander.wang@linux.intel.com> > > > > > > It gets sdw runtime information from dai to prepare stream. > > > > > > Signed-off-by: Rander Wang <rander.wang@linux.intel.com> > > > Signed-off-by: Pierre-Louis Bossart > > > <pierre-louis.bossart@linux.intel.com> > > > > While the patch looks good, the commit message is questionable. You may > > simply state why it is added only just now. Judging from the commit > > title, it has been added to make the sdw dai driver interface complete. > > The commit message is not great but it's not wrong either...
And it doesn't harm to elaborate and explain things rather than have reviewer play detective!
-- ~Vinod
| |