Messages in this thread | | | From | "Jianyong Wu (Arm Technology China)" <> | Subject | RE: [RFC PATCH v6 4/7] time: Add mechanism to recognize clocksource in time_get_snapshot | Date | Fri, 8 Nov 2019 02:34:57 +0000 |
| |
Hi tglx,
> -----Original Message----- > From: Thomas Gleixner <tglx@linutronix.de> > Sent: Thursday, November 7, 2019 3:56 PM > To: Jianyong Wu (Arm Technology China) <Jianyong.Wu@arm.com> > Cc: netdev@vger.kernel.org; yangbo.lu@nxp.com; john.stultz@linaro.org; > pbonzini@redhat.com; sean.j.christopherson@intel.com; maz@kernel.org; > richardcochran@gmail.com; Mark Rutland <Mark.Rutland@arm.com>; > will@kernel.org; Suzuki Poulose <Suzuki.Poulose@arm.com>; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > kvmarm@lists.cs.columbia.edu; kvm@vger.kernel.org; Steve Capper > <Steve.Capper@arm.com>; Kaly Xin (Arm Technology China) > <Kaly.Xin@arm.com>; Justin He (Arm Technology China) > <Justin.He@arm.com>; nd <nd@arm.com> > Subject: Re: [RFC PATCH v6 4/7] time: Add mechanism to recognize > clocksource in time_get_snapshot > > On Thu, 24 Oct 2019, Jianyong Wu wrote: > > From: Thomas Gleixner <tglx@linutronix.de> > > > > In some scenario like return device time to ptp_kvm guest, we need > > identify the current clocksource outside core time code. > > > > This patch add a mechanism to recognize the current clocksource by > > export clocksource id in time_get_snapshot. > > Please check Documentation/process/submitting-patches.rst and search for > 'This patch'. >
Yeah, the expression should be more impersonal.
> > diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h > > index b21db536fd52..ac8016b22734 100644 > > --- a/include/linux/clocksource.h > > +++ b/include/linux/clocksource.h > > @@ -19,6 +19,7 @@ > > #include <linux/of.h> > > #include <asm/div64.h> > > #include <asm/io.h> > > +#include <linux/clocksource_ids.h> > > Please place that include to the other linux includes. You might notice that > there is ordering here. > Ok,
> But where is that include? It's not part of that series, so how is this supposed > to compile?
OMG! Sorry, I added this file when I prepared my patches but missed to include it into this patch! This must be avoid latter.
Thanks Jianyong
> > Thanks, > > tglx
| |