Messages in this thread | | | From | Abhishek Pandit-Subedi <> | Subject | [PATCH v2 0/4] Bluetooth: hci_bcm: Additional changes for BCM4354 support | Date | Thu, 7 Nov 2019 15:27:08 -0800 |
| |
While adding support for the BCM4354, I discovered a few more things that weren't working as they should have.
First, we disallow serdev from setting the baudrate on BCM4354. Serdev sets the oper_speed first before calling hu->setup() in hci_uart_setup(). On the BCM4354, this results in bcm_setup() failing when the hci reset times out.
Next, we add support for setting the PCM parameters, which consists of a pair of vendor specific opcodes to set the pcm parameters. The documentation for these params are available in the brcm_patchram_plus package (i.e. https://github.com/balena-os/brcm_patchram_plus). This is necessary for PCM to work properly.
All changes were tested with rk3288-veyron-minnie.dts.
Changes in v2: - Use match data to disallow baudrate setting - Parse pcm parameters by name instead of as a byte string - Fix prefix for dt-bindings commit
Abhishek Pandit-Subedi (4): Bluetooth: hci_bcm: Disallow set_baudrate for BCM4354 Bluetooth: btbcm: Support pcm configuration Bluetooth: hci_bcm: Support pcm params in dts dt-bindings: net: broadcom-bluetooth: Add pcm config
.../bindings/net/broadcom-bluetooth.txt | 11 ++++ drivers/bluetooth/btbcm.c | 35 +++++++++++ drivers/bluetooth/btbcm.h | 10 ++++ drivers/bluetooth/hci_bcm.c | 58 ++++++++++++++++++- 4 files changed, 112 insertions(+), 2 deletions(-)
-- 2.24.0.rc1.363.gb1bccd3e3d-goog
| |