lkml.org 
[lkml]   [2019]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] phy: allwinner: Fix GENMASK misuse
    Date
    Arguments are supposed to be ordered high then low.

    Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
    ---
    Spotted while trying to add compile time checks of GENMASK arguments.
    Patch has only been compile tested.

    drivers/phy/allwinner/phy-sun50i-usb3.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c
    index 1169f3e83a6f..b1c04f71a31d 100644
    --- a/drivers/phy/allwinner/phy-sun50i-usb3.c
    +++ b/drivers/phy/allwinner/phy-sun50i-usb3.c
    @@ -49,7 +49,7 @@
    #define SUNXI_LOS_BIAS(n) ((n) << 3)
    #define SUNXI_LOS_BIAS_MASK GENMASK(5, 3)
    #define SUNXI_TXVBOOSTLVL(n) ((n) << 0)
    -#define SUNXI_TXVBOOSTLVL_MASK GENMASK(0, 2)
    +#define SUNXI_TXVBOOSTLVL_MASK GENMASK(2, 0)

    struct sun50i_usb3_phy {
    struct phy *phy;
    --
    2.24.0
    \
     
     \ /
      Last update: 2019-11-07 21:48    [W:4.156 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site