Messages in this thread | | | From | Alex Deucher <> | Date | Wed, 6 Nov 2019 12:15:30 -0500 | Subject | Re: [PATCH 7/7] drm/amdgpu: remove set but not used variable 'mc_shared_chmap' |
| |
On Mon, Nov 4, 2019 at 8:54 AM yu kuai <yukuai3@huawei.com> wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function > ‘gfx_v8_0_gpu_early_init’: > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:1713:6: warning: variable > ‘mc_shared_chmap’ set but not used [-Wunused-but-set-variable] > > Fixes: 0bde3a95eaa9 ("drm/amdgpu: split gfx8 gpu init into sw and hw parts") > Signed-off-by: yu kuai <yukuai3@huawei.com>
Looks like gfx_v7_0.c and gfx_v6_0.c could have the same treatment. Care to send patches?
Applied the series. Thanks!
Alex
> --- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > index e4c645d..80b7958 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > @@ -1710,7 +1710,7 @@ static int gfx_v8_0_do_edc_gpr_workarounds(struct amdgpu_device *adev) > static int gfx_v8_0_gpu_early_init(struct amdgpu_device *adev) > { > u32 gb_addr_config; > - u32 mc_shared_chmap, mc_arb_ramcfg; > + u32 mc_arb_ramcfg; > u32 dimm00_addr_map, dimm01_addr_map, dimm10_addr_map, dimm11_addr_map; > u32 tmp; > int ret; > @@ -1850,7 +1850,6 @@ static int gfx_v8_0_gpu_early_init(struct amdgpu_device *adev) > break; > } > > - mc_shared_chmap = RREG32(mmMC_SHARED_CHMAP); > adev->gfx.config.mc_arb_ramcfg = RREG32(mmMC_ARB_RAMCFG); > mc_arb_ramcfg = adev->gfx.config.mc_arb_ramcfg; > > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
| |